On Tue, Apr 18, 2023 at 03:39:54PM -0700, Bart Van Assche wrote:
> +/**
> + * blk_rq_is_seq_zoned_write() - Whether @rq is a zoned write for which the order matters.
Maybe:
* blk_rq_is_seq_zoned_write() - check if @rq needs zoned write serialization
> +bool blk_rq_is_seq_zoned_write(struct request *rq)
> +{
> + switch (req_op(rq)) {
> + case REQ_OP_WRITE:
> + case REQ_OP_WRITE_ZEROES:
> + return blk_rq_zone_is_seq(rq);
> + case REQ_OP_ZONE_APPEND:
> + default:
The REQ_OP_ZONE_APPEND case here is superflous.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
