On 4/13/23 15:59, Christoph Hellwig wrote:
> On Thu, Apr 13, 2023 at 03:54:31PM +0900, Damien Le Moal wrote:
>>> void blk_mq_requeue_request(struct request *rq, bool kick_requeue_list)
>>> {
>>> + struct request_queue *q = rq->q;
>>
>> Nit: not really needed given that it is used in one place only.
>> You could just call "blk_mq_kick_requeue_list(rq->q)" below.
>
> It is needed, because we can't dereference rq safely after
> blk_mq_add_to_requeue_list returns.
Ah, yes, indeed. Sorry for the noise.
