Re: [PATCH 16/20] blk-mq: don't kick the requeue_list in blk_mq_add_to_requeue_list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 13, 2023 at 03:54:31PM +0900, Damien Le Moal wrote:
> >  void blk_mq_requeue_request(struct request *rq, bool kick_requeue_list)
> >  {
> > +	struct request_queue *q = rq->q;
> 
> Nit: not really needed given that it is used in one place only.
> You could just call "blk_mq_kick_requeue_list(rq->q)" below.

It is needed, because we can't dereference rq safely after
blk_mq_add_to_requeue_list returns.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux