On Wed, Apr 05, 2023 at 06:57:49PM +0000, Chaitanya Kulkarni wrote:
>
> > + if ! _detect_nvmet_subsys_attr "attr_qid_max"; then
> > + SKIP_REASONS+=("missing attr_qid_max feature")
> > + return 1
> > + fi
> > +
> > + truncate -s 512M "${file_path}"
> > +
> > + _create_nvmet_subsystem "${subsys_name}" "${file_path}" \
> > + "b92842df-a394-44b1-84a4-92ae7d112861"
>
> by checking following after create subsystem in testcase itself
> we avoid whole process of creating and deleting subsystem and
> additional function in the rc file, because we are already creating
> subsystem as a part of the testcase :-
>
> local attr="${NVMET_CFS}/subsystems/${subsys_name}/attr_qid_max"
>
> #above tow vars go top of this function
>
> if [ -f "${attr}" ];then
> SKIP_REASONS+=("missing attr_qid_max feature")
> #do appropriate error handling and jump to unwind code
> fi
>
> again please ignore this comment if decision has been made to
> keep it this way for some reason...
Again, no decision here. I think I overengineered this part slightly. Indeed if
we are goint to setup a controller anyway we should try to avoid double work.
This should also speed up the test slightly.
Talking about execution time, I was thinking on reducing the timeout value
to reduce the overall runtime.
