On Wed, Apr 05, 2023 at 06:39:43PM +0000, Chaitanya Kulkarni wrote: > this is only used in the testcase patch #4, until we get a second > user move it to patch #4 ? > > in case this was already discussed and decision made to keep it > in rc, please ignore this comment. There wasn't any decision on this topic. I was not sure if I should put it in rc but I saw there are already _set_nvmet_*() functions. Thus I came to the conclusion it makes maintaining these helper function simpler in future because they are all in one file. If someone touches all _set_nvmet_*() function this one is not forgotten. The same goes for the other rc helpers (patch 1-3). That said, I really do not insit in putiting in rc.
