Re: [PATCH 1/2] block: open code __blk_account_io_start()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 27, 2023 at 12:34:26AM -0700, Chaitanya Kulkarni wrote:
> There is only one caller for __blk_account_io_start(), the function
> is small enough to fit in its caller blk_account_io_start().
> 
> Remove the function and opencode in the its caller
> blk_account_io_start().

Having the account slow path in a separate function actually is nice,
same for the next patch.

> +		/*
> +		 * All non-passthrough requests are created from a bio with one
> +		 * exception: when a flush command that is part of a flush sequence
> +		 * generated by the state machine in blk-flush.c is cloned onto the
> +		 * lower device by dm-multipath we can get here without a bio.
> +		 */

... and now you've created a totally messed up block comment expanding
over 80 characters.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux