On Tue, Mar 07, 2023 at 07:55:32AM +0100, Hannes Reinecke wrote: > On 3/6/23 18:37, Matthew Wilcox wrote: > > On Mon, Mar 06, 2023 at 01:01:23PM +0100, Hannes Reinecke wrote: > > > - page = alloc_page(gfp | __GFP_ZERO | __GFP_HIGHMEM); > > > - if (!page) > > > + folio = folio_alloc(gfp | __GFP_ZERO, 0); > > > + if (!folio) > > > > Did you drop HIGHMEM support on purpose? > > No; I thought that folios would be doing that implicitely. > Will be re-adding. We can't ... not all filesystems want to allocate every folio from HIGHMEM. eg for superblocks, it often makes more sense to allocate the folio from lowmem than allocate it from highmem and keep it kmapped. The only GFP flag that folios force-set is __GFP_COMP because folios by definition are compound pages.
