On 2/16/23 9:14 AM, Christoph Hellwig wrote: > On Thu, Feb 16, 2023 at 09:12:33AM -0700, Jens Axboe wrote: >> On 2/16/23 9:05 AM, Christoph Hellwig wrote: >>> Looks good: >>> >>> Reviewed-by: Christoph Hellwig <hch@xxxxxx> >>> >>>> Cc: stable@xxxxxxxxxxxxxxx # 5.10+ >>> >>> But why is this a stable candidate? >> >> Only because the other patches depend on it. > > But none of those is stable material either as I can tell. It's > a fairly simple and nice to have enhancement, but not really a > grave bug or regression fix. It causes a big perf regression when swapping between IO backends, and even caused confusion for that initial reporter. So while it's not a very important crash fix, I do think shoving into stable is prudent. -- Jens Axboe