Re: [PATCH v3 8/9] scsi: core: Set BLK_SUB_PAGE_SEGMENTS for small max_segment_size values

[Bart Van Assche <bvanassche@xxxxxxx>]

On 1/18/23 21:38, Christoph Hellwig wrote:
> > +	if (shost->max_segment_size && shost->max_segment_size < PAGE_SIZE)
> > +		blk_queue_flag_set(QUEUE_FLAG_SUB_PAGE_SEGMENTS, q);
>
> Independ of me really not wanting this code at all if we can avoid it:
> this has no business in the SCSI midlayer or drivers.  Once the config
> option is enabled, setting the flag should happen inside
> blk_queue_max_segment_size.

Hi Christoph,

Thanks for having taken a look. I will move this code into the block layer.

Thanks,

Bart.