> + if (shost->max_segment_size && shost->max_segment_size < PAGE_SIZE) > + blk_queue_flag_set(QUEUE_FLAG_SUB_PAGE_SEGMENTS, q); Independ of me really not wanting this code at all if we can avoid it: this has no business in the SCSI midlayer or drivers. Once the config option is enabled, setting the flag should happen inside blk_queue_max_segment_size.