On 1/10/23 7:37 AM, David Howells wrote: > Jens Axboe <axboe@xxxxxxxxx> wrote: > >> I think it makes more sense to have NO_REF check, to be honest, as that >> means the general path doesn't have to set that flag. But I don't feel >> too strongly about that part. > > It's just that the logic seems weird with BIO_NO_PAGE_REF and BIO_PAGE_PINNED > being kind of opposite polarity. > > Anyway, see attached. Yeah, I guess I'll have to agree with you. So let's go with that approach instead, but then please: 1) Change that flag as a prep patch so you don't mix up the two 2) Incorporate the feedback from the previous patch Any chance we can get that cleanup_mode thing cleaned up as well? -- Jens Axboe
