Re: [PATCH 01/13] blk-mq: avoid sleep in blk_mq_alloc_request_hctx

[Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>]

Hi, Christoph.
on 12/23/2022 1:37 PM, Christoph Hellwig wrote:
> On Fri, Dec 23, 2022 at 08:52:11PM +0800, Kemeng Shi wrote:
>> +	if (WARN_ON_ONCE(((!flags) & (BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_RESERVED))))
> 
> This check does not make any sense.  I think what you want is
> 
> 	if (WARN_ON_ONCE(!(flags & BLK_MQ_REQ_NOWAIT) ||
> 	    WARN_ON_ONCE(!(flags & BLK_MQ_REQ_RESERVED))))
This is exactly what I want and I will fix this in next version. Thanks.

-- 
Best wishes
Kemeng Shi