Re: [PATCH 01/13] blk-mq: avoid sleep in blk_mq_alloc_request_hctx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH 01/13] blk-mq: avoid sleep in blk_mq_alloc_request_hctx
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 23 Dec 2022 06:37:18 +0100
Cc: axboe@xxxxxxxxx, dwagner@xxxxxxx, hare@xxxxxxx, ming.lei@xxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, hch@xxxxxx, john.garry@xxxxxxxxxx
In-reply-to: <20221223125223.1687670-2-shikemeng@huaweicloud.com>
References: <20221223125223.1687670-1-shikemeng@huaweicloud.com> <20221223125223.1687670-2-shikemeng@huaweicloud.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Fri, Dec 23, 2022 at 08:52:11PM +0800, Kemeng Shi wrote:
> +	if (WARN_ON_ONCE(((!flags) & (BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_RESERVED))))

This check does not make any sense.  I think what you want is

	if (WARN_ON_ONCE(!(flags & BLK_MQ_REQ_NOWAIT) ||
	    WARN_ON_ONCE(!(flags & BLK_MQ_REQ_RESERVED))))

Follow-Ups:
- Re: [PATCH 01/13] blk-mq: avoid sleep in blk_mq_alloc_request_hctx
  - From: Kemeng Shi

References:
- [PATCH 00/13] A few bugfix and cleanup patches for blk-mq
  - From: Kemeng Shi
- [PATCH 01/13] blk-mq: avoid sleep in blk_mq_alloc_request_hctx
  - From: Kemeng Shi

Prev by Date: [PATCH 04/13] blk-mq: Fix potential io hung for shared sbitmap per tagset
Next by Date: Re: [PATCH 12/13] blk-mq: use switch/case to improve readability in blk_mq_try_issue_list_directly
Previous by thread: [PATCH 01/13] blk-mq: avoid sleep in blk_mq_alloc_request_hctx
Next by thread: Re: [PATCH 01/13] blk-mq: avoid sleep in blk_mq_alloc_request_hctx
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]