On 11/30/22 20:15, Shinichiro Kawasaki wrote: [...] >>> + if (zone_no >= dev->nr_zones) { >>> + pr_err("Sector out of range\n"); >>> + return -EINVAL; >>> + } >>> + >>> + if (dev->zones[zone_no].type == BLK_ZONE_TYPE_CONVENTIONAL) { >>> + pr_err("Can not change condition of conventional zones\n"); >> >> Why ? Conventional zones can go read-only or offline too. At least on >> ZBC/ZAC SMR HDDs, they can. So allowing this to happen with null_blk is >> desired too. > > As far as I refer ZBC r05 Table 10 and ZAC r05 Table 5, conventional zones can > have only zone condition "NOT WRITE POINTER". I think the tables show that the > zone conditions "READ ONLY" and "OFFLINE" are valid for sequential write > required zones (and sequential write preferred zones). Do I misinterpret the > specs? Indeed, it looks like it. You are correct. So no read-only or offline for conventional zones it is. -- Damien Le Moal Western Digital Research