Printing e->elevator_name in all cases improves the readability. Suggested-by: Christoph Hellwig <hch@xxxxxx> Signed-off-by: Jinlong Chen <nickyc975@xxxxxxxxxx> --- block/elevator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/elevator.c b/block/elevator.c index ffa750976d25..b2f2252f29e7 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -777,7 +777,7 @@ ssize_t elv_iosched_show(struct request_queue *q, char *name) spin_lock(&elv_list_lock); list_for_each_entry(e, &elv_list, list) { if (e == cur) - len += sprintf(name+len, "[%s] ", cur->elevator_name); + len += sprintf(name+len, "[%s] ", e->elevator_name); else if (elv_support_features(q, e)) len += sprintf(name+len, "%s ", e->elevator_name); } -- 2.34.1