On Tue, Oct 25, 2022 at 05:09:21PM -0600, Keith Busch wrote: > As far as naming them goes, if the only usage is its definition, then > what's the point? If there's a use for a named enum somewhere else, then > yah, that improves readability. I think it is nice bit of documentation. E.g. if the enum is for the bits or value in a nvme filed naming it after that field can be handy.