On Mon, Oct 03, 2022 at 01:16:36PM +0300, Max Gurtovoy wrote: >> I'd make this named nvme_pr_type > > Most of the enums of this header are not named. > > I don't understand what is the convention here. > > Usually, if it's not a new header file I'm trying to keep the file > convention and this is what I did. > > If all agree on named, I'll send another version. I think named is better, nvme has some weird unnamed enums that even combine totally unrelated fields which I always found confusing.
