On Oct 24, 2022 / 14:32, Yi Zhang wrote: > On Mon, Oct 24, 2022 at 8:50 AM Shinichiro Kawasaki > <shinichiro.kawasaki@xxxxxxx> wrote: ... > > From Yi's observation, I found a couple of improvement opportunities which are > > beyond scope of this fix. Here I note them as memorandum (patches are welcome :) > > I resend the patch to set log size to 64M and another two which could > address below :) Thanks! I'll wait for comment by Chaitanya then review your patches. > > > > > 1) Assuming nvme device size 1GB define in nvme/012 and nvme/013 has relation to > > the fio I/O size 950m defined in common/xfs, these values should be defined > > at single place. Probably we should define both in nvme/012 and nvme/013. > > > > 2) The fio I/O size 950m is defined in _xfs_run_fio_verify_io() which is called > > from nvme/035. Then, it is implicitly assumed that TEST_DEV for nvme/035 has > > size 1GB (or larger). I found that nvme/035 fails with 512MB nvme device. > > We should fix this by calculating fio I/O size from TEST_DEV size. (Or > > require 1GB nvme device size for the test case.) > > > > -- > > Shin'ichiro Kawasaki > > > > > -- > Best Regards, > Yi Zhang > -- Shin'ichiro Kawasaki
