Re: Issue in blk_mq_alloc_request_hctx()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/10/2022 15:54, Bart Van Assche wrote:
On 10/21/22 04:16, John Garry wrote:
-    return blk_mq_rq_ctx_init(&data, blk_mq_tags_from_data(&data), tag,
+    rq = blk_mq_rq_ctx_init(&data, blk_mq_tags_from_data(&data), tag,
                      alloc_time_ns);
+    if (!rq)
+        goto out_queue_exit;
+
+    rq->__data_len = 0;
+    rq->__sector = (sector_t) -1;
+    rq->bio = rq->biotail = NULL;
+    return rq;

Hi John,

Shouldn't the new struct request member initializations be moved into blk_mq_rq_ctx_init() such that all blk_mq_rq_ctx_init() callers are fixed?

That would seem reasonable. I just wonder why it was not there in the first place.

Anyway, I'll look to make that change.

thanks,
John



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux