On 21/10/2022 15:54, Bart Van Assche wrote:
On 10/21/22 04:16, John Garry wrote:
- return blk_mq_rq_ctx_init(&data, blk_mq_tags_from_data(&data), tag,
+ rq = blk_mq_rq_ctx_init(&data, blk_mq_tags_from_data(&data), tag,
alloc_time_ns);
+ if (!rq)
+ goto out_queue_exit;
+
+ rq->__data_len = 0;
+ rq->__sector = (sector_t) -1;
+ rq->bio = rq->biotail = NULL;
+ return rq;
Hi John,
Shouldn't the new struct request member initializations be moved into
blk_mq_rq_ctx_init() such that all blk_mq_rq_ctx_init() callers are fixed?
That would seem reasonable. I just wonder why it was not there in the
first place.
Anyway, I'll look to make that change.
thanks,
John
