Re: Issue in blk_mq_alloc_request_hctx()

[Bart Van Assche <bvanassche@xxxxxxx>]

On 10/21/22 04:16, John Garry wrote:
> -    return blk_mq_rq_ctx_init(&data, blk_mq_tags_from_data(&data), tag,
> +    rq = blk_mq_rq_ctx_init(&data, blk_mq_tags_from_data(&data), tag,
>                       alloc_time_ns);
> +    if (!rq)
> +        goto out_queue_exit;
> +
> +    rq->__data_len = 0;
> +    rq->__sector = (sector_t) -1;
> +    rq->bio = rq->biotail = NULL;
> +    return rq;

Hi John,

Shouldn't the new struct request member initializations be moved into 
blk_mq_rq_ctx_init() such that all blk_mq_rq_ctx_init() callers are fixed?

Thanks,

Bart.