On Mon, Oct 17, 2022 at 02:53:20PM +0800, Ye Bin wrote: > + if (bt->trace_state == Blktrace_running) > + blk_trace_switch_state(bt, 0); AFAICS blk_trace_switch_state already has that state check, so there should be no need to duplicate it here. I think having this call in blk_trace_cleanup itself might be a little more obvious, too.