Re: [PATCH -next 1/3] blktrace: introduce 'blk_trace_swicth_state' helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 17, 2022 at 02:53:19PM +0800, Ye Bin wrote:
> +static int blk_trace_switch_state(struct blk_trace *bt, int start)

This is a very confusing helper.  Please split it into two helpers
(e.g. blk_trace_{start,stop}) instead of the awakward int used as
boolean argument that makes it do two entirely unrelated things.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux