Re: [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Serge Semin <fancer.lancer@xxxxxxxxx>
Subject: Re: [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 26 Sep 2022 16:39:59 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>, Jonathan Derrick <jonathan.derrick@xxxxxxxxx>, Revanth Rajashekar <revanth.rajashekar@xxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx>, Pavel Parkhomenko <Pavel.Parkhomenko@xxxxxxxxxxxxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20220925222325.irltbraf4e2j4vtq@mobilestation>
References: <20220909191916.16013-1-Sergey.Semin@baikalelectronics.ru> <20220909191916.16013-2-Sergey.Semin@baikalelectronics.ru> <20220910053045.GA23052@lst.de> <20220910123542.tzxg2blegw55z5fj@mobilestation> <20220912082909.GA10666@lst.de> <20220925222325.irltbraf4e2j4vtq@mobilestation>
User-agent: Mutt/1.5.17 (2007-11-01)

On Mon, Sep 26, 2022 at 01:23:25AM +0300, Serge Semin wrote:
> IMO both the approaches seem unclear if a reader doesn't know what
> they have been introduced for. Anyway do you insist on using the
> kmalloc-ed buffer here instead? If so I'll resubmit the series with
> this patch updated accordingly.

I don't like the __aligend version too much, but I can live with it if
you strongly prefer it.

Follow-Ups:
- Re: [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer
  - From: Serge Semin

References:
- [PATCH 0/2] block/nvme: Fix DMA-noncoherent platforms support
  - From: Serge Semin
- [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer
  - From: Serge Semin
- Re: [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer
  - From: Christoph Hellwig
- Re: [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer
  - From: Serge Semin
- Re: [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer
  - From: Christoph Hellwig
- Re: [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer
  - From: Serge Semin

Prev by Date: Re: [PATCH 1/2] block: modify blk_mq_plug() to allow only reads for zoned block devices
Next by Date: Re: [PATCH 1/2] block: modify blk_mq_plug() to allow only reads for zoned block devices
Previous by thread: Re: [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer
Next by thread: Re: [PATCH 1/2] nvme-hwmon: Cache-line-align the NVME SMART log-buffer
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]