On Aug 30, 2022 / 16:26, Sagi Grimberg wrote:
[...]
> > Unfortunately, your patch does not avoid the failure after the recent commit
> > 06a0ba866d90 ("common/rc: avoid module load in _have_driver()"). As the commit
> > title says, _have_driver no longer has the side-effect to leave the dh_generic
> > module loaded. Instead, I suggest to load dh_generic in the test() function:
> >
> > diff --git a/tests/nvme/043 b/tests/nvme/043
> > index 381ae75..dbe9d3f 100755
> > --- a/tests/nvme/043
> > +++ b/tests/nvme/043
> > @@ -40,6 +40,8 @@ test() {
> >
> > _setup_nvmet
> >
> > + modprobe -q dh_generic
> > +
> > truncate -s 512M "${file_path}"
> >
> > _create_nvmet_subsystem "${subsys_name}" "${file_path}"
> > @@ -88,5 +90,7 @@ test() {
> >
> > rm "${file_path}"
> >
> > + modprobe -qr dh_generic
> > +
> > echo "Test complete"
> > }
> >
>
> That's fine with me, can you prepare an alternative patch for it?
Sure, will post it soon.
--
Shin'ichiro Kawasaki
