Hi Sagi,
On Aug 29, 2022 / 11:36, Sagi Grimberg wrote:
> Signed-off-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
> ---
> tests/nvme/043 | 1 +
> tests/nvme/044 | 1 +
> tests/nvme/045 | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/tests/nvme/043 b/tests/nvme/043
> index 381ae755f140..87273e5b414d 100755
> --- a/tests/nvme/043
> +++ b/tests/nvme/043
> @@ -16,6 +16,7 @@ requires() {
> _have_kernel_option NVME_TARGET_AUTH
> _require_nvme_trtype_is_fabrics
> _require_nvme_cli_auth
> + _have_driver dh_generic
> }
Do you see failure without this check? As far as I understand, this new check is
equivalent to '_have_kernel_option CRYPTO_DH'. This test case already requires
'_have_kernel_option NVME_AUTH' and CONFIG_NVME_AUTH selects CONFIG_CRYPTO_DH.
So, the new check does not look required assuming dh_generic.ko is built and
installed correctly.
>
>
> diff --git a/tests/nvme/044 b/tests/nvme/044
> index 046553198ce3..13019659b951 100755
> --- a/tests/nvme/044
> +++ b/tests/nvme/044
> @@ -16,6 +16,7 @@ requires() {
> _have_kernel_option NVME_TARGET_AUTH
> _require_nvme_trtype_is_fabrics
> _require_nvme_cli_auth
> + _have_driver dh_generic
> }
>
>
> diff --git a/tests/nvme/045 b/tests/nvme/045
> index b60f18fc9f87..264f21053921 100755
> --- a/tests/nvme/045
> +++ b/tests/nvme/045
> @@ -16,6 +16,7 @@ requires() {
> _have_kernel_option NVME_TARGET_AUTH
> _require_nvme_trtype_is_fabrics
> _require_nvme_cli_auth
> + _have_driver dh_generic
> }
>
>
> --
> 2.34.1
>
--
Shin'ichiro Kawasaki
