On Tue, Aug 2, 2022 at 2:35 PM Jens Axboe <axboe@xxxxxxxxx> wrote: > > > As to testing, I'm going to punt that question to Hannes and Christoph, > as I have no way of testing that particular NVMe feature. I can't test the *feature* either. But dammit, I test two very different build configurations, and both of them failed miserably on this file. Don't you get it? That file DOES NOT EVEN COMPILE. I refuse to have anything to do with a pull request that doesn't even pass some very fundamental build requirements for me. That implies a level of lack of testing that just makes me go "No way am I touching that tree". Linus