On Fri, Jul 29, 2022 at 03:29:52PM +0800, Ming Lei wrote: > The parameter passed from userspace is added to one array, and the type is > used as index of the array. The following patch will add two parameter > types: basic(covers basic queue setting and misc settings which can't be grouped A bunch of overly long lines here. But I still think this is the wrong design. The number of potential parameter is very limited, so splitting them over multiple ioctls and data structure for no good reason is really a de-optimization that makes the code more complex and slower.