On Fri, Jul 29, 2022 at 03:29:51PM +0800, Ming Lei wrote: > get_device(&ub->cdev_dev); > ret = add_disk(disk); > if (ret) { > + /* > + * has to drop the reference since ->free_disk won't be > + * called in case of add_disk failure > + */ Nit: Multi-line comments typically start with a capitalized word and end with a dot to form a proper sentence. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>