Re: [PATCH 1/6] block: simplify blktrace sysfs attribute creation

[Bart Van Assche <bvanassche@xxxxxxx>]

On 6/23/22 22:25, Christoph Hellwig wrote:
> diff --git a/block/genhd.c b/block/genhd.c
> index bf9be06af2c8d..12b0eda8d125b 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -1134,6 +1134,9 @@ static struct attribute_group disk_attr_group = {
>   
>   static const struct attribute_group *disk_attr_groups[] = {
>   	&disk_attr_group,
> +#ifdef CONFIG_BLK_DEV_IO_TRACE
> +        &blk_trace_attr_group,
> +#endif

The space in front of '&' is probably unintended? Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>