Re: [RFC PATCH 0/6] reduce the size of rnbd_clt_dev

[Guoqing Jiang <guoqing.jiang@xxxxxxxxx>]

Hi Jinpu,

On 6/21/22 8:16 PM, Jinpu Wang wrote:
> On Mon, Jun 20, 2022 at 5:49 AM Guoqing Jiang <guoqing.jiang@xxxxxxxxx> wrote:
> > Hi,
> >
> > The struct rnbd_clt_dev added some members (wc, fua and max_hw_sectors
> > etc) which are used to set up gendisk and request_queue, but seems only
> > map scenario need to setup them since rnbd_client_setup_device is not
> > called from remap path.
> >
> > Previously, pahole reports.
> >
> >          /* size: 272, cachelines: 5, members: 29 */
> >          /* sum members: 259, holes: 4, sum holes: 13 */
> >          /* last cacheline: 16 bytes */
> >
> > After the series, it changes to
> > t
> >          /* last cacheline: 32 bytes */
> >
> > Please review.
> >
> > Thanks,
> > Guoqing
> Hi Guoqing,
>
> Thanks for the patchset, I had a brief look, in general I like the
> idea, will run a regression test. and sort out the details.

Thanks for the review!

Thanks,
Guoqing