On Mon, Jun 20, 2022 at 5:49 AM Guoqing Jiang <guoqing.jiang@xxxxxxxxx> wrote: > > Hi, > > The struct rnbd_clt_dev added some members (wc, fua and max_hw_sectors > etc) which are used to set up gendisk and request_queue, but seems only > map scenario need to setup them since rnbd_client_setup_device is not > called from remap path. > > Previously, pahole reports. > > /* size: 272, cachelines: 5, members: 29 */ > /* sum members: 259, holes: 4, sum holes: 13 */ > /* last cacheline: 16 bytes */ > > After the series, it changes to > > /* size: 224, cachelines: 4, members: 17 */ > /* last cacheline: 32 bytes */ > > Please review. > > Thanks, > Guoqing Hi Guoqing, Thanks for the patchset, I had a brief look, in general I like the idea, will run a regression test. and sort out the details. Thanks! Jinpu