On 6/17/22 2:44 PM, Bart Van Assche wrote: > Fix the following warnings: > > block/bfq-cgroup.c:721: warning: Function parameter or member 'bfqg' not described in '__bfq_bic_change_cgroup' > block/bfq-cgroup.c:721: warning: Excess function parameter 'blkcg' description in '__bfq_bic_change_cgroup' > block/bfq-cgroup.c:870: warning: Function parameter or member 'ioprio_class' not described in 'bfq_reparent_leaf_entity' > block/bfq-cgroup.c:900: warning: Function parameter or member 'ioprio_class' not described in 'bfq_reparent_active_queues' > > Cc: Jan Kara <jack@xxxxxxx> > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > --- > block/bfq-cgroup.c | 4 +++- > block/bfq-wf2q.c | 2 ++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c > index dc0fa93219df..abc251902e28 100644 > --- a/block/bfq-cgroup.c > +++ b/block/bfq-cgroup.c > @@ -709,7 +709,7 @@ void bfq_bfqq_move(struct bfq_data *bfqd, struct bfq_queue *bfqq, > * __bfq_bic_change_cgroup - move @bic to @cgroup. > * @bfqd: the queue descriptor. > * @bic: the bic to move. > - * @blkcg: the blk-cgroup to move to. > + * @bfqg: the blk-cgroup to move to. bfqg is the bfq group, not the block cgroup. -- Jens Axboe