On Tue, Feb 08, 2022 at 02:26:38PM -0800, Bart Van Assche wrote: > On 2/8/22 13:21, Luis Chamberlain wrote: > > And the return value shoudl be $? not $1. I couldn't test srp so wanted > > someone who would to help review, but sure, I should have caught this. > > Hmm ... the SRP tests can be run inside a virtual machine so it is not clear > to me what prevents to run these tests? OK I've managed to get time to run SRP tests on a virtual environement but I'm a bit surprised as to the failures found. I need this baseline to ensure the change does not regress anything. I'll report the failures next.. Luis
