Wenchao Hao, what you're saying makes a lot of sense but it raises a lot of questions in turn. Fabio, did you test your patch? This is another reason why syzbot should display the whole dmesg because otherwise we can't ask people link to their test results if it just says "PASSED" with no additional information. If syzbot provided a dmesg at the end then I would require a link to it under the --- cut off line for patches that I review. In a way this gets back to the original testing that syzbot did do. If Wenchao's reading of the code is correct the Fabio's patch caused a series of use after free bugs but because the test results just said "PASSED" with no additional information. Either way, failing to call device_del() is still a bug. Also, I don't really understand why we don't have to call put_device(&sdkp->disk_dev) at the end of sd_remove(). regards, dan carpenter
