Re: [PATCH] scsi: sd: call device_del() if device_add_disk() fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: <fmdefrancesco@xxxxxxxxx>
Subject: Re: [PATCH] scsi: sd: call device_del() if device_add_disk() fails
From: Wenchao Hao <haowenchao@xxxxxxxxxx>
Date: Thu, 31 Mar 2022 11:26:22 -0400
Cc: <axboe@xxxxxxxxx>, <dan.carpenter@xxxxxxxxxx>, <jejb@xxxxxxxxxxxxx>, <linux-block@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-scsi@xxxxxxxxxxxxxxx>, <martin.petersen@xxxxxxxxxx>, <syzbot+f08c77040fa163a75a46@xxxxxxxxxxxxxxxxxxxxxxxxx>, <syzkaller-bugs@xxxxxxxxxxxxxxxx>, <linfeilong@xxxxxxxxxx>, <haowenchao@xxxxxxxxxx>
In-reply-to: <20220329154948.10350-1-fmdefrancesco@gmail.com>
References: <20220329154948.10350-1-fmdefrancesco@gmail.com>

I do not think it's necessary to call device_del() on this path. If the device
has been added, put_device() would delete it from sysfs. So the origin error
handle is ok with me.

Follow-Ups:
- Re: [PATCH] scsi: sd: call device_del() if device_add_disk() fails
  - From: Dan Carpenter

References:
- [PATCH] scsi: sd: call device_del() if device_add_disk() fails
  - From: Fabio M. De Francesco

Prev by Date: Re: [LSF/MM/BPF TOPIC] block drivers in user space
Next by Date: Re: [PATCH] block/psi: make PSI annotations of submit_bio only work for file pages
Previous by thread: Re: [PATCH] scsi: sd: call device_del() if device_add_disk() fails
Next by thread: Re: [PATCH] scsi: sd: call device_del() if device_add_disk() fails
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux