Currently, udev change event is generated for a loop device before the device is ready for IO. Due to serialization on lo->lo_mutex in lo_open() this does not matter because anybody is able to open the device and do IO only after the configuration is finished. However this synchronization in lo_open() is going away so make sure userspace reacting to the change event will see the new device state by generating the event only when the device is setup. Signed-off-by: Jan Kara <jack@xxxxxxx> --- drivers/block/loop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 3e636a75c83a..e401afc3e6dc 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -608,6 +608,8 @@ static int loop_change_fd(struct loop_device *lo, struct block_device *bdev, loop_update_dio(lo); blk_mq_unfreeze_queue(lo->lo_queue); partscan = lo->lo_flags & LO_FLAGS_PARTSCAN; + /* Notify userspace about device change when it is ready for IO */ + disk_force_media_change(lo->lo_disk, DISK_EVENT_MEDIA_CHANGE); loop_global_unlock(lo, is_loop); /* @@ -1020,7 +1022,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode, goto out_unlock; } - disk_force_media_change(lo->lo_disk, DISK_EVENT_MEDIA_CHANGE); set_disk_ro(lo->lo_disk, (lo->lo_flags & LO_FLAGS_READ_ONLY) != 0); INIT_WORK(&lo->rootcg_work, loop_rootcg_workfn); @@ -1068,6 +1069,7 @@ static int loop_configure(struct loop_device *lo, fmode_t mode, if (partscan) lo->lo_disk->flags &= ~GENHD_FL_NO_PART; + disk_force_media_change(lo->lo_disk, DISK_EVENT_MEDIA_CHANGE); loop_global_unlock(lo, is_loop); if (partscan) loop_reread_partitions(lo); -- 2.34.1 --umwtnzhqcn5ic4i7--
