Christoph, > dev is very hard to grab for. grep? > Give the field a more descriptive name and documents it's purpose. its > + > + /* > + * This device is mostly just used to show a bunch of attributes in a > + * weird place. In doubt don't add any new users, and most importantly > + * don't use if for any actual refcounting. > + */ > + struct device disk_dev; I agree with Bart that this should be more explicit about the /sys/class/scsi_disk location. Otherwise it is not clear which device the comment refers to. Otherwise OK. Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen Oracle Linux Engineering
