Re: [PATCH 03/14] scsi: don't use disk->private_data to find the scsi_driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 03/14] scsi: don't use disk->private_data to find the scsi_driver
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 07 Mar 2022 22:16:12 -0500
Cc: Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, Bart Van Assche <bvanassche@xxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx
In-reply-to: <20220304160331.399757-4-hch@lst.de> (Christoph Hellwig's message of "Fri, 4 Mar 2022 17:03:20 +0100")
Organization: Oracle Corporation
References: <20220304160331.399757-1-hch@lst.de> <20220304160331.399757-4-hch@lst.de>

Christoph,

> Requiring every ULP to have the scsi_drive as first member of the
> private data is rather fragile and not necessary anyway.  Just use
> the driver hanging off the SCSI device instead.

Looks fine.

Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- move more work to disk_release v3
  - From: Christoph Hellwig
- [PATCH 03/14] scsi: don't use disk->private_data to find the scsi_driver
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 02/14] blk-mq: handle already freed tags gracefully in blk_mq_free_rqs
Next by Date: Re: [PATCH 04/14] sd: rename the scsi_disk.dev field
Previous by thread: Re: [PATCH 03/14] scsi: don't use disk->private_data to find the scsi_driver
Next by thread: [PATCH 05/14] sd: call sd_zbc_release_disk before releasing the scsi_device reference
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]