On 2/16/22 16:20, Christoph Hellwig wrote:
On Wed, Feb 16, 2022 at 04:18:43PM +0100, Hannes Reinecke wrote:
My turn to be picky:
In the previous patch you use 'set_bit()' for GD_DEAD, which to my
knowledge doesn't imply a memory barrier.
Yet here you rely on that for the 'test_bit()' to return the correct/most
recent value.
Don't we need a memory barrier here somewhere?
Well, we only do the test to skip useless work. A race is not a
problem here.
Ok.
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
