On Mon, Jan 17, 2022 at 12:21:37AM -0800, Christoph Hellwig wrote:
>
> > * systems and other upper level users of the block layer should use
> > * submit_bio() instead.
> > */
> > -void submit_bio_noacct(struct bio *bio)
> > +void __submit_bio_noacct(struct bio *bio, bool check)
> > {
> > - if (unlikely(!submit_bio_checks(bio)))
> > + if (unlikely(check && !submit_bio_checks(bio)))
> > return;
>
> This doesn't make sense as an API - you can just move the checks
> into the caller that pass check=true.
But submit_bio_checks() is local helper, and it is hard to make it
public to drivers. Not mention there are lots of callers to
submit_bio_noacct().
Thanks,
Ming
