Hello Guys,
Lining reported that iops limit throttle doesn't work on dm-thin, also
iops limit throttle works bad on plain disk in case of excessive split.
Commit 4f1e9630afe6 ("blk-throtl: optimize IOPS throttle for large IO scenarios")
was for addressing this issue, but the taken approach is just to run
post-accounting, then current split bios won't be throttled actually,
so actual iops throttle result isn't good in case of excessive bio
splitting.
The 1st two patches are cleanup.
The 3rd and 4th patches add one new helper of __submit_bio_noacct() for
blk_throtl_dispatch_work_fn(), so that bios won't be throttled any more
when blk-throttle code dispatches throttled bios.
The 5th and 6th patch makes the real difference for throttling split bio wrt.
iops limit.
The last patch is to revert commit 4f1e9630afe6 ("blk-throtl: optimize IOPS
throttle for large IO scenarios").
Lining, you should get exact IOPS throttling in your dm-thin test with
this patchset, please test and feedback.
Ming Lei (7):
block: move submit_bio_checks() into submit_bio_noacct
block: move blk_crypto_bio_prep() out of blk-mq.c
block: allow to bypass bio check before submitting bio
block: don't check bio in blk_throtl_dispatch_work_fn
block: throttle split bio in case of iops limit
block: don't try to throttle split bio if iops limit isn't set
block: revert 4f1e9630afe6 ("blk-throtl: optimize IOPS throttle for
large IO scenarios")
block/blk-core.c | 32 +++++++++-------------
block/blk-merge.c | 2 --
block/blk-mq.c | 3 ---
block/blk-throttle.c | 61 +++++++++++++++---------------------------
block/blk-throttle.h | 16 ++++++-----
include/linux/blkdev.h | 7 ++++-
6 files changed, 51 insertions(+), 70 deletions(-)
--
2.31.1
