On Thu, 16 Dec 2021 02:14:44 -0800 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Wed, Dec 15, 2021 at 08:21:28PM +0100, Miko Larsson wrote: > > strlcpy shouldn't be used; strscpy should be used instead. > > I think the proper API to use here would be kmemdup_nul. Thanks for the heads-up! That only seems to apply to the assignment of 'file_name'. The usage of strscpy seems to be correct in the other two cases, though (since they're char arrays.) I suspect I might be wrong though, since my knowledge of C is shabby at best.