Re: [PATCH 2/2] zram: zram_drv: replace strlcpy with strscpy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Miko Larsson <mikoxyzzz@xxxxxxxxx>
Subject: Re: [PATCH 2/2] zram: zram_drv: replace strlcpy with strscpy
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 16 Dec 2021 02:14:44 -0800
Cc: minchan@xxxxxxxxxx, ngupta@xxxxxxxxxx, senozhatsky@xxxxxxxxxxxx, axboe@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <20211215192128.108967-3-mikoxyzzz@gmail.com>
References: <20211215192128.108967-1-mikoxyzzz@gmail.com> <20211215192128.108967-3-mikoxyzzz@gmail.com>

On Wed, Dec 15, 2021 at 08:21:28PM +0100, Miko Larsson wrote:
> strlcpy shouldn't be used; strscpy should be used instead.

I think the proper API to use here would be kmemdup_nul.

Follow-Ups:
- Re: [PATCH 2/2] zram: zram_drv: replace strlcpy with strscpy
  - From: Miko Larsson

References:
- [PATCH 0/2] zram: zram_drv: Fix some formatting problems
  - From: Miko Larsson
- [PATCH 2/2] zram: zram_drv: replace strlcpy with strscpy
  - From: Miko Larsson

Prev by Date: Re: [PATCH 1/2] zram: zram_drv: add SPDX license identifiers
Next by Date: RE: [PATCH] blk-mq: avoid to iterate over stale request
Previous by thread: [PATCH 2/2] zram: zram_drv: replace strlcpy with strscpy
Next by thread: Re: [PATCH 2/2] zram: zram_drv: replace strlcpy with strscpy
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux