On 10/19/21 7:36 AM, Christoph Hellwig wrote: > On Tue, Oct 19, 2021 at 06:08:34AM -0600, Jens Axboe wrote: >> If we have just one queue type in the plug list, then we can extend our >> direct issue to cover a full plug list as well. > > I don't think this description matches what the code does. My impression > of what the code does it: > > If a plug only has requests for a single queue, and that queue does not > use an I/O scheduler, we can just issue the list of requests directly > from the plug. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> I'll expand it a bit, that is what I was trying to say, but it just became too brief. -- Jens Axboe