On 10/19/21 7:34 AM, Christoph Hellwig wrote: > On Tue, Oct 19, 2021 at 06:08:33AM -0600, Jens Axboe wrote: >> + !from_schedule); >> + blk_mq_sched_insert_requests(this_hctx, this_ctx, >> + &list, from_schedule); >> + depth = 0; >> + this_hctx = rq->mq_hctx; >> + this_ctx = rq->mq_ctx; >> + >> } >> >> + list_add(&rq->queuelist, &list); > > I think this needs to be a list_add_tail to keep the request ordered. I think it does the right thing, the singly linked list is LIFO, so we effectively just reverse it here. -- Jens Axboe
