Re: [PATCH 1/9] block: define io_batch structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 14, 2021 at 09:50:10AM -0600, Jens Axboe wrote:
> On 10/13/21 11:45 PM, Christoph Hellwig wrote:
> > On Wed, Oct 13, 2021 at 10:54:08AM -0600, Jens Axboe wrote:
> >> This adds the io_batch structure, and a helper for defining one on the
> >> stack. It's meant to be used for collecting requests for completion,
> >> with a completion handler defined to be called at the end.
> > 
> > Isn't the name a little misleading given that it is all about
> > completions?
> 
> It is for completions, but I'd rather just keep it short for now.

I'd go for something like io_comp_batch or something like that at least.

> > Also I wonder if this should be merged with the next patch as that's
> > sortof a logical unit.
> 
> Actually was like that before, I can fold them again.

I'm fine either way.  Merged just seems a little more logical.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux