On 10/14/21 9:30 AM, Jens Axboe wrote: > On 10/14/21 1:43 AM, Christoph Hellwig wrote: >> On Wed, Oct 13, 2021 at 10:54:13AM -0600, Jens Axboe wrote: >>> +void nvme_complete_batch_req(struct request *req) >>> +{ >>> + nvme_cleanup_cmd(req); >>> + nvme_end_req_zoned(req); >>> + req->status = BLK_STS_OK; >>> +} >>> +EXPORT_SYMBOL_GPL(nvme_complete_batch_req); >>> + >> >> I'd be tempted to just merge this helper into the only caller. >> nvme_cleanup_cmd is exported anyway, so this would just add an export >> for nvme_end_req_zoned. > > Sure, I can do that. That'll turn it into two calls from the batch completion though, so I skipped this change. -- Jens Axboe