On 10/13/21 11:00 PM, Christoph Hellwig wrote: > On Wed, Oct 13, 2021 at 11:57:51AM -0600, Jens Axboe wrote: >> It's not like they are conditionally enabled, if you get one you get >> the other. But I can shuffle it around if it means a lot to you... > > As I've been trying to reshuffle the files and data structures to > keep the bio and requests bits clearly separated I'd appreciate if we > can keep the status codes in core.c and just do the long overdue move > the request completion helers. Fair enough, I'll leave the error stuff in blk-core, doesn't really matter anyway as it should be out-of-line. > And as said before: I think we should fix the trace point to not > unconditionally call the status to errno conversion first as not doing > it at all for the fast path will be even faster than inlining it :) I'll do that as separate patch on top. -- Jens Axboe
