Re: [PATCH 4/4] block: move update request helpers into blk-mq.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 13, 2021 at 11:46:40AM -0600, Jens Axboe wrote:
> On 10/13/21 11:32 AM, Christoph Hellwig wrote:
> > On Wed, Oct 13, 2021 at 10:49:37AM -0600, Jens Axboe wrote:
> >> For some reason we still have them in blk-core, with the rest of the
> >> request completion being in blk-mq. That causes and out-of-line call
> >> for each completion.
> >>
> >> Move them into blk-mq.c instead.
> > 
> > The status/errno helpers really are core code.  And if we change
> > the block_rq_complete tracepoint to just take the status and do the
> > conversion inside the trace event to avoid the fast path out of line
> > call.
> 
> It's all core code at this point imho, there's on request based without
> mq.

But the errno mapping is just as relevant for bio based drivers.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux