On Wed, Oct 13, 2021 at 11:46:40AM -0600, Jens Axboe wrote: > On 10/13/21 11:32 AM, Christoph Hellwig wrote: > > On Wed, Oct 13, 2021 at 10:49:37AM -0600, Jens Axboe wrote: > >> For some reason we still have them in blk-core, with the rest of the > >> request completion being in blk-mq. That causes and out-of-line call > >> for each completion. > >> > >> Move them into blk-mq.c instead. > > > > The status/errno helpers really are core code. And if we change > > the block_rq_complete tracepoint to just take the status and do the > > conversion inside the trace event to avoid the fast path out of line > > call. > > It's all core code at this point imho, there's on request based without > mq. But the errno mapping is just as relevant for bio based drivers.