> On Sep 21, 2021, at 4:21 AM, Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx> wrote:
>
> From: Chaitanya Kulkarni <kch@xxxxxxxxxx>
>
> The local variable file is used to pass it to the vfs_fsync(). We can
> get away with using lo->lo_backing_file instead of storing in a local
> variable which is not used anywhere else.
>
> No functional change in this patch.
>
> Signed-off-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>
> ---
> drivers/block/loop.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 51c42788731a..6478d3b0dd2a 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -498,8 +498,7 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos,
>
> static int lo_req_flush(struct loop_device *lo, struct request *rq)
> {
> - struct file *file = lo->lo_backing_file;
> - int ret = vfs_fsync(file, 0);
> + int ret = vfs_fsync(lo->lo_backing_file, 0);
> if (unlikely(ret && ret != -EINVAL))
> ret = -EIO;
>
> --
> 2.29.0
>
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
